[illumos-Developer] Webrev for bug 81: remove 'is_z_a_power_of_x_le_y' from pcfs utils
Gary Mills
mills at cc.umanitoba.ca
Fri Jul 15 08:54:33 PDT 2011
On Fri, Jul 15, 2011 at 10:11:23AM -0400, Eric Schrock wrote:
>
> Looks good to me. The first parameter to IS_IN_RANGE() is always 1 -
> perhaps renaming it to something like IS_POSITIVE_LE(max) would make
> more sense? I'm not wedded to it, just a suggestion.
I wanted to have it that way for generality. Maybe someday somebody
will need a range that starts from 0 or 2. The value of 1 was implied
by the functions, but never mentioned in their comments.
--
-Gary Mills- -Unix Group- -Computer and Network Services-
More information about the Developer
mailing list