[illumos-Developer] [RE-REVIEW] 1230 need support for recent gcc stdarg builtins (and 1240 va_*.h use non-existent __GNUC_MINOR)

Garrett D'Amore garrett at damore.org
Fri Jul 22 07:24:04 PDT 2011


LGTM too, except you need to fix your commit comments.

	- Garrett

On Fri, 2011-07-22 at 12:19 +0400, Igor Kozhukhov wrote:
> LGTM
> 
> Best regards,
> Igor
> 
> > From: Richard Lowe <richlowe at richlowe.net>
> > Date: Fri, 22 Jul 2011 04:06:53 -0400
> > To: "developer at lists.illumos.org" <developer at lists.illumos.org>
> > Subject: [illumos-Developer] [RE-REVIEW] 1230 need support for recent gcc
> > stdarg builtins (and 1240 va_*.h use non-existent __GNUC_MINOR)
> > 
> > I would like this re-reviewed in the context of, and alongside
> >    1240 va_*.h use non-existent __GNUC_MINOR
> > 
> > http://richlowe.net/webrevs/il_1240
> > 
> > Surprising, but easy to confirm (and I invite you to! perhaps I've
> > lost my mind).  I found this in a final test pass of #1230, thanks to
> > gcc 3.4 taking a path other than that which I expected.
> > 
> > (I plan for these to be a single changeset when I push, for the sake of
> > sanity)
> > 
> > -- Rich
> > 
> > _______________________________________________
> > Developer mailing list
> > Developer at lists.illumos.org
> > http://lists.illumos.org/m/listinfo/developer
> 
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list