[illumos-Developer] Webrev for bug 561: Strange characters when executing "format"

[Gary Mills]

On Fri, Jul 22, 2011 at 07:33:27AM -0700, Garrett D'Amore wrote:
> On Thu, 2011-07-21 at 08:06 -0500, Gary Mills wrote:
> > On Sat, Jul 09, 2011 at 09:13:32PM -0500, Gary Mills wrote:
> > > > 
> > > > The three values in the inquiry data are space-padded in fixed-length
> > > > fields, not null terminated.  The code to create a disk name from this
> > > > data already exists as the get_generic_disk_name() function in the
> > > > `format' source.  I'll be posting a new webrev soon with this function
> > > > substituted.  Unfortunately, I can't test it, but it pretty well has
> > > > to work.
> > > 
> > > My new webrev is at:
> > > 
> > >     http://cr.illumos.org/view/4z5nj2vk/illumos561-1/
> > 
> > Any interest in this one?  I've had no reviews of the revised webrev

Now I have.  I'm rebuilding it again with an anonmyous struct.

> LGTM.
> 
> Your padding in your prototype is a bit... hmm.. strange.  I'd have
> indented far less.

I moved the prototype from one file to another without changing the
indentation.  It should match the other prototypes.  Yes, I wouldn't
ordinarily use that much indentation either.

> Also, I'd have taken this opportunity to yank
> support for the K&R prototypes -- we don't still need legacy pre-ANSI
> support in our headers.

I didn't know about that.  Is there a list of things that bug fixers
should do in addition to fixing the bug and preparing the webrev?  So
far I know of:

  o Remove `#pragma ident'
  o Add copyright notice
  o Style check

-- 
-Gary Mills-        -Unix Group-        -Computer and Network Services-