[illumos-Developer] [REVIEW] 1279 err(3C) should be marked __NORETURN

Garrett D'Amore garrett at damore.org
Wed Jul 27 17:52:54 PDT 2011


It looks OK to me.

	- Garrett

On Wed, 2011-07-27 at 19:40 -0400, Richard Lowe wrote:
> 1279 err(3C) should be marked __NORETURN
> 
> webrev:
>   http://richlowe.net/webrevs/il_1279
> 
> err* and friends exit, and thus don't return.  GCC would prefer to
> know this, so it doesn't warn "control reaches end of non-void
> function" when that's really not the case.  I introduced such a
> warning into jdtrace some months ago, and didn't spot it because it is
> unfortunately not built with the shadow enabled (it seems we only
> shadow compilation to intermediate objects).
> 
> Thanks,
> 
> -- Rich
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list