[illumos-Developer] [REVIEW] 1303 Grub should support large sector disks

[Robert Mustacchi]

On 7/29/11 8:47 AM, Hans Rosenfeld wrote:
> Hi,
>
> our Grub currently fails to boot large sector disks (with ashift != 9).
>
> Here is a webrev to fix this: http://cr.illumos.org/view/6qc99xkh/
>
> I took the liberty to also do some minor cleanups of the code I had to
> touch. I tested it on my laptop, which has (at this time) two rpools,
> one with ashift=12 on a 4k-disk, and another with ashift=9.
>
> The patched grub is able to boot both pools, regardless of which disk it
> was loaded from.
>
>
> Hans
>

I don't have enough familiarity with the grub and ZFS interactions to 
comment on that, but it looks like you've added the variable trace (line 
67) and it isn't used anywhere in the webrev.

Robert