[illumos-Developer] [REVIEW] 1303 Grub should support large sector disks

[Hans Rosenfeld]

On Fri, Jul 29, 2011 at 05:47:23PM +0200, Hans Rosenfeld wrote:
> our Grub currently fails to boot large sector disks (with ashift != 9).
> 
> Here is a webrev to fix this: http://cr.illumos.org/view/6qc99xkh/
> 
> I took the liberty to also do some minor cleanups of the code I had to
> touch. I tested it on my laptop, which has (at this time) two rpools,
> one with ashift=12 on a 4k-disk, and another with ashift=9.
> 
> The patched grub is able to boot both pools, regardless of which disk it
> was loaded from.

As I learned the hard way today, the code still has a bug and doesn't
work for mirrored pools. It tries to read the ashift from the individual
members of a mirror vdev, but the ashift is a vdev property.

An updated webrev can be found here: http://cr.illumos.org/view/77bat2me/

I also did a few more cleanups for better readability and removed the
unused trace variable that I accidentally introduced previously.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown