[illumos-Developer] Webrev for bug 323: Need fix for glob()resource exhaustion

[Garrett D'Amore]

If it isn't code you introduced, then you need not worry about these nits.  (That said I'd probably clean them anyway, but that might make the diffs a lot bigger.)

  -- Garrett D'Amore

On Jun 6, 2011, at 4:53 PM, "Gary Mills" <mills at cc.umanitoba.ca> wrote:

> On Mon, Jun 06, 2011 at 02:54:58AM +0400, Garrett D'Amore wrote:
>> line 662 you should use NULL instead of casting zero
> 
> That's part of the old code, but fortunately there's only one
> like that.
> 
>> line 659 use of explicit register decl is probably pointless
> 
> This is also from the old code.  I believe the compiler ignores them.
> There are 44 of these.  Should I remove all of them, or just the one
> that appeared in the diff.
> 
>> otherwise these changes look good to me.
> 
> -- 
> -Gary Mills-        -Unix Group-        -Computer and Network Services-
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer