[illumos-Developer] Webrev for bug 323: Need fix for glob()resource exhaustion

[Garrett D'Amore]

Looks good to me.

  -- Garrett D'Amore

On Jun 7, 2011, at 11:40 PM, Gary Mills <mills at cc.umanitoba.ca> wrote:

> On Mon, Jun 06, 2011 at 05:05:40PM +0400, Garrett D'Amore wrote:
>> 
>> If it isn't code you introduced, then you need not worry about these
>> nits.  (That said I'd probably clean them anyway, but that might
>> make the diffs a lot bigger.)
> 
> I decided to fix the two that I disturbed with my fixes.  Here's
> the new webrev:
> 
>    http://cr.illumos.org/view/o1j9woho/illumos323-1/
> 
> Here's a test of the fixed FTP server that illustrates the new
> behavior:
> 
>    ftp> mls * lfile
>    output to local-file: lfile? 
>    200 PORT command successful.
>    150 Opening ASCII mode data connection for file list.
>    226 Transfer complete.
>    local: lfile remote: *
>    51 bytes received in 0.00018 seconds (278.29 Kbytes/s)
>    ftp> mls {..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/* lfile2
>    output to local-file: lfile2? y
>    200 PORT command successful.
>    550 Arguments too long
>    ftp> mls {..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*/{..,..,..}/*cx lfile3
>    output to local-file: lfile3? y
>    200 PORT command successful.
>    550 Arguments too long
> 
> -- 
> -Gary Mills-        -Unix Group-        -Computer and Network Services-