[illumos-Developer] parseable numbers from zpool/zfs, and libgrubmgmt

Robert Mustacchi rm at joyent.com
Fri Jun 10 11:14:21 PDT 2011


Changes look good to me as well.

Robert

On 6/9/11 5:22 PM, Eric Schrock wrote:
> You should update the manpages (usr/src/man/man1), but otherwise LGTM.
>
> - Eric
>
> On Thu, Jun 9, 2011 at 7:54 PM, David Pacheco<dap at joyent.com>  wrote:
>
>> On Thu, Jun 9, 2011 at 3:25 PM, Eric Schrock<eric.schrock at delphix.com>wrote:
>>
>>> If you were feeling really paranoid, you could create a new
>>> zpool_prop_get() to match zfs_prop_get(), and leave the old zpool_get_prop()
>>> around, but I think that's just overkill.
>>>
>>
>>
>> I agree.  I've wrapped up these changes and they appear to work fine
>> (though I still want to test out some more corner cases).  Anyone care to
>> take a look?  The webrev is here:
>>
>> http://www.cs.brown.edu/~dap/webrev-zfs/
>>
>> Thanks in advance.
>>
>> -- Dave
>>
>
>
>
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer




More information about the Developer mailing list