[illumos-Developer] kstat_delete interface

[Steve Gonczi]

Greetings, 

I recently have been looking at a crash in the stmf code, where a couple of 
kstats appear to point to recycled kstat entries. 
(itl_kstat_info and itl_kstat_taskq) 

The ks_module is "caps" instead of "stmf", and the ks_name is 
"nprocs_task_xxx" instead of the expected names. So that leads me to believe 
these kstats has been freed/recycled. 

This brings me to the question: would it not make sense to set any kstat 
pointers to NULL after they have been freed? 

Looking at the kstat_delete() implementation, it seems like the natural place 
to do this. 

Arguably, the "right solution" would be to change the interface to kstat_delete() 
from 
-kstat_delete ( kstat_t * ksp ) 
+kstat_delete ( kstat_t ** ksp ) 
so that it can set the *ksp to NULL when it is done freeing the memory 
that it points to. 

Unfortunately kstat_delete() is called in 170 places. 

This is clearly a problem.. Any opinions? 


Steve 




/sG/ 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.illumos.org/pipermail/developer/attachments/20110614/2fe3ffad/attachment.html>