[illumos-Developer] cfmakeraw (was: First Illumos patches)

[Albert Lee]

I've made some changes for the following minor issues:

libbc's headers shouldn't be modified - libbc is for SunOS 4.x compatibility.

Style nit (beginning line with operator, indent):
+       termios_p->c_iflag &= ~(IGNBRK|BRKINT|PARMRK|ISTRIP
+                               |INLCR|IGNCR|ICRNL|IXON)

Should be:
+       termios_p->c_iflag &= ~(IGNBRK|BRKINT|PARMRK|ISTRIP|
+           INLCR|IGNCR|ICRNL|IXON);


-Albert

On Fri, Jun 17, 2011 at 7:10 AM, Andrew Stormont
<andrew.stormont at nexenta.com> wrote:
> Hi Cyril,
>
> Does this look right?
>
> Thanks,
> Andy
>
> On 12/06/2011 20:30, "Cyril Plisko" <cyril.plisko at mountall.com> wrote:
>
>>On Sun, Jun 12, 2011 at 10:26 PM, Andrew Stormont
>><andrew.stormont at nexenta.com> wrote:
>>> Hi Cyril,
>>>
>>> No reason. I just didn't think it was necessary.
>>>
>>> I will update the patch to set c_cc[VMIN] and c_cc[VTIME] if you think
>>> it's a good idea.
>>>
>>
>>Yes, please. I believe it may not work as expected otherwise.
>>
>>--
>>Regards,
>>        Cyril
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfmakeraw.diff
Type: application/octet-stream
Size: 5156 bytes
Desc: not available
URL: <http://lists.illumos.org/pipermail/developer/attachments/20110617/24ada62b/attachment.obj>