[illumos-Developer] [REVIEW] 1121 smbsrv should use SPNEGO (outbound authentication)

[Albert Lee]

Some observations, although this looks correct as it is:

usr/src/lib/smbsrv/libmlsvc/common/dssetup_clnt.c:91: Don't need to
bzero here, dssetup_get_domain_info clobbers it.

usr/src/lib/smbsrv/libmlsvc/common/smbrdr_glue.c:65: Only
smbrdr_logon() caller remaining is SMB_DR_JOIN ... ->
smbd_join_domain->mlsvc_join. That could be replaced with direct usage
of smbrdr_ctx_new() and passing the ctx around.

usr/src/lib/smbsrv/libmlsvc/common/smbrdr_glue.c:118: ndr_rpc_bind()
is passed the username MLSVC_ANON_USER ("IPC$") in a couple of places,
also whatever is returned by mb_ipc_get_user().

-Albert

On Thu, Jun 16, 2011 at 11:08 PM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> Please review:
>  http://www.yalms.org/cr/illumos-1121/
>
> This is part two (of two) for adding SPNEGO to the outbound
> authentication path in smbsrv.  (part one is issue 1120, or
> the part that falls in netsmb and smbfs, sent earlier).
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>