[illumos-Developer] [REVIEW] 1120 Use real file descriptors for smbfs named pipes.

[Gordon Ross]

Did I miss some?  (in new code)  If so, it was just a slip-up.

On Sun, Jun 19, 2011 at 9:46 PM, Eric Schrock <eric.schrock at delphix.com> wrote:
> LGTM.  The mismatched braces with if/else still really bugs me - it's
> against the ON style rules, but something that the cstyle tool doesn't check
> ("if one arm of an if-else statement contains braces, all arms should
> contain braces").  I'm all for avoiding superfluous scorched-earth style
> fixes of legacy code, but if we're adding new code, what value do we gain by
> maintaining this paradigm?  That being said, if you really think there are
> clear benefits to the long-term maintainability of the code I won't stand in
> your way.
> Thanks,
>
> - Eric
>
> On Sat, Jun 18, 2011 at 1:23 AM, Gordon Ross <gordon.w.ross at gmail.com>
> wrote:
>>
>> Webrev updated, same place:
>>  http://www.yalms.org/cr/illumos-1120/
>>
>> Thanks,
>> Gordon
>
>
>
> --
> Eric Schrock
> Delphix
> 275 Middlefield Road, Suite 50
> Menlo Park, CA 94025
> http://www.delphix.com
>