[illumos-Developer] webrev for 1073: migrate kernel modules from ancient _depends_on to true ELF dependencies

[Bayard Bell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adam,

I wasn't sure about the appropriate copyright, either. There are a couple of places where the location of the copyright may be wrong (e.g. it didn't follow the CDDL block and thus isn't clearly attached to CDDL use terms). Where the copyright lines follow the CDDL block and the Nexenta line looks like the below, I'd think this is reasonable because both SMI/Oracle and Nexenta are providing the code under the same license terms, but I'm not aware of any ordering implications (I'm a SoC intern for Nexenta, which is to say that I've not got a solid or even a tenuous grip on a cluestick with this).

As far as the dependencies not being simply copied, I don't think any dependencies were removed that should be there (or at all). A number of Makefiles already had partial or complete dependency lists even as the code continued to contain _depends_on lists (e.g. usr/src/uts/fs/nfs/nfs_server.c specifies a dependency on misc/klmmod, while usr/src/uts/(intel|sparc)/ nfssrv/Makefile already included that and a somewhat longer list. I double-checked my edits against the grep I used to track all of the edits, but it's still possible that I may have missed something for lack of understanding. What caught your attention?

Cheers,
Bayard

On 27 Jun 2011, at 08:39, Adam Leventhal wrote:

> Hey Bayard,
> 
> There are several places where you've split up the copyright that's
> currently there:
> 
>  # Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
> + # Copyright (c) 2011 Nexenta Systems, Inc. All rights reserved.
>  # Use is subject to license terms.
> 
> I don't think that's the correct form, but I'm really not sure.
> 
> It also doesn't look like these dependencies were copied blithely into
> the Makefiles, but that some edits were made. Was this intentional?
> 
> Thanks.
> 
> Adam
> 
> 
> On Sun, Jun 26, 2011 at 6:56 AM, Bayard Bell
> <buffer.g.overflow at googlemail.com> wrote:
>> http://dev1.illumos.org/~buffyg/illumos-1073-webrev/
>> _______________________________________________
>> Developer mailing list
>> Developer at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/developer
>> 
>> 
> 
> 
> 
> -- 
> Adam Leventhal, Delphix
> http://dtrace.org/blogs/ahl
> 
> 275 Middlefield Road, Suite 50
> Menlo Park, CA 94025
> http://www.delphix.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.12 (Darwin)

iQIcBAEBAgAGBQJOCEUYAAoJEHm5cBpJ87doZTcP/jnkLsHmQ8I2psw5/3M4WBtt
VJ0kgeMitDue+7he0PwDI0x5yLEA6BWPScNxAl8cHw/FSOwOV0kgGJYzynY1dYwv
7jLISvNBG1pRddjNWHVkG/z+ooyyEr6mJnURsj7f4CWaZizEiU50JrJcmbTITGIl
kPdCvX0sHH0MgUvNUUIfBerV08qjBp9KG1KwDy1UjfLH/3KbAsC2FwevhitQo8LZ
N4TBBNWbNfwA8djXR69nOeYQaO5c4CHFznqfnjCLM7GrduJ+jKa0jfcoltPRK2ae
WqkUAOechhxYwfbG1CTt/DpGpSW7v8wyPU/vmHcDKXkd9CD32tfNK6WKJeFJYtDS
0M/tuDpW/7pvQ7YrdM3+BRfEztvwAIcIpBb5TE8b76Nnf9EGuf8ZoxTjckgPRL6b
utzsVyCu16gFAEIPFCuWyuvQLaI51FLyAogiQivPyoxn8sjt6sWxpXRl0fX/qao0
g6GcvbavC74sGk2zn+62r3fvn/79IZ+nAj5WQT8pC5YSFKtiELx9qQVJ2DZOjTGH
u4YWzQZe+Y1s8DE+8cGWRxRf/OOehSxYDflqenAxNqNZ3IbWI4+iC2suHfL4kTUN
dDLOBehUiWDEfFHE1tgTQNTbsb3DA0JbBAI2NdsXFr2LPbH4IOJQOZxvaIgQkFke
zuaOlNp7Cdqtse8c8R2F
=Hwuw
-----END PGP SIGNATURE-----