[illumos-Developer] webrev & design change: blkdev should support dump

[Garrett D'Amore]

On Thu, 2011-06-30 at 04:44 +0400, Alexey Zaytsev wrote:
> On Thu, Jun 30, 2011 at 01:13, Garrett D'Amore <garrett at nexenta.com> wrote:
> > As part of some some future support coming (virtio block device
> > support), I've added support for dump(9e) to blkdev.  This necessitated
> > some changes to the blkdev API, as it turns out that I need to be able
> > to *read* a label from a blkdev device even with interrupts disabled.
> >
> > The webrev is here:
> >
> > http://mexico.purplecow.org/gdamore/webrev/blkdevdump/
> 
> Hey.
> 
> I think you forgot to remove the
> +           (P2PHASE(nblk, 1U << bd->d_blkshift) != 0)) {
> from bd_dump().

Oh crap.  I forgot about that.  I'll fix it.


> 
> Otherwise, it's identical to what I have, so feel free to add a
> 
> Tested-by: Alexey Zaytsev <alexey.zaytsev at nexenta.com>

We don't give such credit, sorry.

	- Garrett
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer