[illumos-Developer] MUCH better --> zil for zvol TRUNCATE (and iSCSI UNMAP) working...

[George Wilson]

On 3/2/11 9:59 AM, Dan McDonald wrote:
> On Wed, Mar 02, 2011 at 08:42:00AM -0800, George Wilson wrote:
> <SNIP!>
>> Great news! If you could make one more change and try the test again:
>>
>> In zvol_replay_truncate() I don't think we need any of the dmu_tx_*
>> stuff. I believe that this can be simplified to just call
>> dmu_free_long_range().
> I dunno... zvol_replay_write() has the dmu_tx_* stuff.  If I rip it out of
> replay_truncate, should I also rip it out of replay_write() as well?

No, in the case of zvol_replay_write() you're updating the contents of 
the zvol in one transaction so it's necessary to create the transaction. 
In the case of zvol_replay_truncate() the dmu_free_long_range() is going 
to create the transactions for you. That's why I don't believe you need 
the dmu_tx_* stuff for that particular op.

- George
> Dan
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer