[illumos-Developer] [REVIEW] 780, 783, 784 gcc build fixes

[Dan McDonald]

On Wed, Mar 09, 2011 at 02:48:03PM -0500, Richard Lowe wrote:
> 
> Dan, I didn't nest the cpr_is_foo checks in a non-ifdef'd condition, as
> you'd asked because I wasn't sure if my response regarding the effectively
> constant nature of cpr_sleeptype made you happy enough or not.

Yeah... it actually did.  The constant in question is referenced in other
bits of non-ifdef-SPARC code, but none of them call unknown functions like
the bits your fixing.

> These changes are sufficient to build with gcc as the primary compiler, and
> boot the resulting bits 32bit in virtualbox.  I don't believe there are
> hardwired uses of Studio cc in the x86 build, as there are on SPARC, but
> haven't checked yet.  I have not had the opportunity to test
> platform-specifics on anything but virtualbox as yet (that is, no 64bit, no
> non-p123 pcbe, etc.).  If you try using gcc as the primary, you may still
> find more bugs.

But these are an improvement over what was.  Count me as an approver!

Dan