[illumos-Developer] Fwd: [Urgend] Round eleven of code review for ksh93-integration+POSIX utility update3 ...

[Garrett D'Amore]

I'm extending the timeout to March 24, 2011, because the code size is
*huge*, and I am the one that has insisted on a review within this group
before I accept the RTI.  One week review is the barest minimum needed
for a cset of this scope.  If someone else is going to review, but needs
more time than even that, please let me know.

	- Garrett

On Thu, 2011-03-17 at 17:31 +0100, ольга крыжановская wrote:
> Illumos developers, I forward the code review request for the POSIX
> utility (aka posixcore) and ksh update 3 to gather feed back from the
> Illumos developers.
> This is the same patch set which is used for Oracle Solaris 11; we
> hope to use almost identical patches for Illumos and Oracle Solaris
> for this time.
> 
> Code review for Oracle Solaris 11 was done by:
> Olga Kryzhanovska <olga.kryzhanovska at gmail.com>, covering AST codebase
> and Solaris Makefiles+packaging
> Chris Pickett <pkchris at users.sourceforge.net>, covering AST codebase
> Irek Szczesniak <iszczesniak at gmail.com>, covering AST codebase and
> Solaris Makefiles+packaging
> Venky <venkytv at opensolaris.org>, for both AST and Solaris parts
> John Wiersba <jonathan.wiersba at gmail.com> for the AST codebase
> There were 3 other Oracle engineers involved in the code review but
> they were not permitted to use their Oracle.COM mail addresses in the
> public.
> 
> I set the time out to Saturday, 19.3.2011, because the code has
> significant coverage and the put back already approved for Oracle
> Solaris.
> 
> Olga
> 
> ---------- Forwarded message ----------
> From: Roland Mainz <roland.mainz at nrubsig.org>
> Date: Fri, Feb 11, 2011 at 4:23 PM
> Subject: [Urgend] Round eleven of code review for
> ksh93-integration+POSIX utility update3 ...
> To: Korn Shell 93 integration/migration project discussion
> <ksh93-integration-discuss at opensolaris.org>
> Cc: Mike Kupfer <mike.kupfer at oracle.com>, Chris Pickett
> <pkchris at users.sourceforge.net>, Garrett D'Amore
> <garrett at nexenta.com>, "I. Szczesniak" <iszczesniak at gmail.com>,
> shell-discuss at opensolaris.org, Olga Kryzhanovska
> <olga.kryzhanovska at gmail.com>, Venky <venkytv at opensolaris.org>
> 
> 
> Hi!
> 
> ----
> 
> I'd like to request another code review for the upcoming
> ksh93-integration+POSIX utility update3 putback. I hope this is the
> final round now that all other feedback has been integrated and the
> codebase has been updated to match ast-ksh.2011-02-08.
> 
> 
> Webrev can be found at
> http://cr.opensolaris.org/~gisburn/on_posix_utility_update2_201100211_017/
> 
> 
> Test binaries for Solaris 11 SPARC and x86 are available from:
> x86: http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/opensolaris_ksh20110208_i686_20110211_rev2361.tar.bz2
> SPARC: http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/opensolaris_ksh20110208_sparc_20110211_rev2361.tar.bz2
> 
> Checksums are:
> $ sum -x sha512 opensolaris_ksh20110208_i686_20110211_rev2361.tar.bz2
> c0c1f9fc5af6f50b56196ef38d5bdcf24cac4ceb81510c0c67fd51b03e96277e1608acef00a50c4001a5601b54da26bf9584e067924e5a8cf587547623f9d1e8
> opensolaris_ksh20110208_i686_20110211_rev2361.tar.bz2
> $ sum -x sha512 opensolaris_ksh20110208_sparc_20110211_rev2361.tar.bz2
> 5712d451f09e12c0d0cce4c02e158832e4a99ab7c782e85ac32b49acbd87c56eb4032fb05c6a6290f50a2aa638adbc7a926faff2e9722dbebe7f2eed2b77a2de
> opensolaris_ksh20110208_sparc_20110211_rev2361.tar.bz
> 
> 
> The hg export file is available at
> http://cr.opensolaris.org/~gisburn/on_posix_utility_update2_201100211_017/on_ksh93_ast_utility_update2_hg_export_20110211_017.hgexport.bz2
> Checksum is:
> $ sum -x sha512
> on_ksh93_ast_utility_update2_hg_export_20110211_017.hgexport.bz2
> 483aa7aae7defb7ab5e14f7f4c7e2d17eb565a456a5b9f03ec8aa873f9174dd972261b959696c040c1413bb29898e2170816cc9e9251333b8e509e0ebbb78146
> on_ksh93_ast_utility_update2_hg_export_20110211_017.hgexport.bz2
> 
> Outstanding issues:
> <none known>
> 
> Timeout is set to 14.2.2011.
> 
> ----
> 
> Bye,
> Roland
> 
> --
>  __ .  . __
>  (o.\ \/ /.o) roland.mainz at nrubsig.org
>  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
>  /O /==\ O\  TEL +49 641 3992797
>  (;O/ \/ \O;)
> 
> 
> 
> -- 
>       ,   _                                    _   ,
>      { \/`o;====-    Olga Kryzhanovska   -====;o`\/ }
> .----'-/`-/     olga.kryzhanovska at gmail.com   \-`\-'----.
>  `'-..-| /       http://twitter.com/fleyta     \ |-..-'`
>       /\/\     Solaris/BSD//C/C++ programmer   /\/\
>       `--`                                      `--`
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer