[illumos-Developer] Review for 166 CR6901979 error in xdr_float.c not fixed

Garrett D'Amore garrett at damore.org
Mon Mar 21 19:52:33 PDT 2011


On Mon, 2011-03-21 at 20:34 -0500, Jason King wrote:
> Ok.. after a few unrelated issues with the sparc build, this tests out
> correctly (using data generated from s10 sparc) and also includes a
> few minor cstyle cleanups in the existing code:
> 
> http://cr.illumos.org/view/x2ewa65v/
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer


xdr.h: line 34.  I don't know who Jason Knig is, but its awful nice of
him to donate his code to us. ;-)

xdr_float.c: do you want to #ifdef the xdr_float_portable?  I.e. not
include it if we have a builtin optimized version?

Otherwise it looks reasonable to me.

	- Garrett




More information about the Developer mailing list