[illumos-Developer] Fwd: [Urgend] Round eleven of code review for ksh93-integration+POSIX utility update3 ...

Joerg Schilling Joerg.Schilling at fokus.fraunhofer.de
Fri Mar 25 10:15:37 PDT 2011


Alan Coopersmith <alan.coopersmith at oracle.com> wrote:

> On 03/17/11 04:51 PM, Richard Lowe wrote:
> > 63,000 lines of diff to go
>
> http://lucasr.org/2011/01/29/micro-commits/

Making commits the right way is something that is really important if you like 
to make a project able to act as an upstream.

Illumos currently is not a nice upstream, importing commits from Illumos into 
Schillix-ON is a hard job for most commits as the commits usually combine 
unrelated tasks. If you like to import one of the sub-tasks but cannot import 
another because it is incompatible, deltas need to be imported manually on a 
file base.

In order to act nicely to potential downstrams, Schillix-ON tries to do it's 
best to avoid bundling unrelated tasks.

One of the worst things in the ksh93 cluster commit is that there is a 
Copyright date change in files that otherwise stay the same. This is something 
I can try to ignore when reading the hg exort output, but it poisons the webrev.

I will probably need at least a week in order to do at least a basic review.

Jörg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       joerg.schilling at fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily



More information about the Developer mailing list