[illumos-Developer] Webrev: support for MHIOC_CLEAR

Garrett D'Amore garrett at damore.org
Mon Mar 28 07:35:58 PDT 2011


On Mon, 2011-03-28 at 09:59 -0400, Dan McDonald wrote:
> Combing through mail, found this:
> 
> On Wed, Mar 09, 2011 at 07:28:47PM -0800, Garrett D'Amore wrote:
> > This contribution comes from Cyril at opensvc.com, and adds support for
> > missing MHIOC_CLEAR.
> > 
> > http://mexico.purplecow.org/gdamore/webrev/scsi-clear/
> > 
> > I'd like feedback... I've reviewed and it looks sane, and the test
> > results Cyril has gotten seem sane, so unless someone objects, this code
> > is likely to integrate.
> 
> Can drv_priv() return other errors besides EPERM?  If so, your code needs to
> take that into account, or else things might occur if drv_priv() returns
> errors that are not EPERM.
> 
> Dan

That code is already integrated.  I'm not aware of any reasonable error
code other than EPERM that drv_priv() can return.

The man page seems to indicate that there aren't any:
        
        RETURN VALUES
             This routine returns 0 if it succeeds, EPERM if it fails.

So I think we're good.

	- Garrett




More information about the Developer mailing list