[illumos-Developer] Review for 719 beadm should allow BEs outside of <rpool>/ROOT

[Dan McDonald]

I'd like it if someone else also took a look at this.

There were other concerns the first time you put this out.  It *seems* they
have been addressed, but I'd like to see other feedback to confirm/deny that.

On Tue, Mar 29, 2011 at 06:50:32PM +0400, Alexander Eremin wrote:
> Requesting code review for #719 beadm should allow BEs outside of
> <rpool>/ROOT
> webrev: http://cr.opensolaris.org/~alhazred/i719
> 
> Fix also contain some cleanup for lint

usr/src/lib/libbe/common/be_create.c
usr/src/lib/libbe/common/be_list.c
usr/src/lib/libbe/common/be_snapshot.c
usr/src/lib/libbe/common/libbe_priv.h

* Looks good, no comments needed.

usr/src/lib/libbe/common/be_utils.c

* Lines 207-210:

  1.) Use ZFS_MAXNAMELEN for the length argument to strlcpy().  This will
      allow you to shorten the strlcpy() call.

  2.) Cstyle nit:  While not called out by the tool, if you have a
      multiple-line single statement, use {} around it anyway for less
      confusion.


Thanks,
Dan