[illumos-Developer] webrev: 650 grep support for -q would be useful

Yuri Pankov yuri.pankov at gmail.com
Thu May 5 14:41:06 PDT 2011


On Thu, May 05, 2011 at 05:09:22PM -0400, Gordon Ross wrote:
> On Thu, May 5, 2011 at 2:13 PM, Garrett D'Amore <garrett at damore.org> wrote:
> > If you couple with C99 enabled, you don't have to worry about changing
> > bool to boolean_t.  C99 specific bool/true/false, I think. :-)
> 
> That's a good suggestion, and could reduce your diffs from BSD a little.
> Here's how you enable C99:
> 
> diff -r d3058c4591e9 usr/src/cmd/grep/Makefile
> --- a/usr/src/cmd/grep/Makefile	Thu May 05 16:38:14 2011 -0400
> +++ b/usr/src/cmd/grep/Makefile	Thu May 05 16:38:49 2011 -0400
> @@ -22,6 +22,7 @@
> 
>  include ../Makefile.cmd
> 
> +C99MODE=	$(C99_ENABLE)
>  CFLAGS +=	$(CCVERBOSE)
>  CPPFLAGS +=	-D_FILE_OFFSET_BITS=64
>  LDLIBS +=	-lz -lbz2

Thanks, guys. It made the diff 326 lines smaller. Webrev and diff
updated.


Yuri



More information about the Developer mailing list