[illumos-Developer] [REVIEW] 945, 946, 947 Joyent SMF changes (svc* -z/-Z and svcs -L)

Garrett D'Amore garrett at damore.org
Thu May 5 22:13:29 PDT 2011


This looks ok to me as well.  Note that I prefer NOTE(ARGUNUSED(x, ...))
to /*ARGSUSED*/, as the former allows to specify exactly which arguments
are unused, while the latter is a wild card for all of them.

	- Garrett

On Fri, 2011-05-06 at 00:45 -0400, Albert Lee wrote:
> The way globals like g_zonename are reused in svcs(1) is a bit
> unsettling but par for the course, I guess.
> 
> -Albert
> 
> On Mon, May 2, 2011 at 7:04 PM, Richard Lowe <richlowe at richlowe.net> wrote:
> > An updated webrev is:
> >
> >  http://richlowe.net/webrevs/il_945.2
> >
> > It errors for -z/-Z from an NGZ in the obvious fashion.  I left the
> > ht_free split in place, since I'd already made the change by the time
> > Bryan disagreed.  (I also made it null out the buckets, and had
> > ht_init assert they were null)
> >
> > I filed #982 regarding what I described as "sketchy error behaviour".
> > In short, /etc/zones/index within a zone contains a reference to the
> > current zone, with the zonepath set to '/', this confuses
> > zone_get_rootpath, which expects the zonepath from zone_get_zonepath
> > to actually be a zone path...
> >
> > -- Rich
> >
> > _______________________________________________
> > Developer mailing list
> > Developer at lists.illumos.org
> > http://lists.illumos.org/m/listinfo/developer
> >
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list