[illumos-Developer] webrev: 696 Incorrect check dma_attr_sgllen <= 0 in rootnex_valid_alloc_parms

[Dan McDonald]

On Fri, May 06, 2011 at 09:56:25PM -0700, Garrett D'Amore wrote:

<SNIP!>

> So, we now properly support the documented use of -1 to indicate no
> limit on the length of the s/g list for DMA.
> 
> I know some will complain about the use of the casts, but I think this
> is the simplest solution and most efficient, to the problem.  (We can't
> change the type, I'd prefer not to change the caller's structure
> directly, I don't like adding extra tests, and even a simple mask
> operation will add more cpu cycles without really adding any additional
> value.)

I'm okay with this after a pass 0, but I'd feel better with a pass 1 review
of my own, AND another opinion from someone with more rootnex experience than
I.

Thanks,
Dan