[illumos-Developer] webrev: 992 towlower/towupper are broken

Garrett D'Amore garrett at damore.org
Mon May 9 23:26:27 PDT 2011


This looks really good to me.  Its a good catch on the first problem,
and your solution to the second is rather elegant (in spite of being
coded up in sed. ;-)

You may submit this to advocates@, or you may wait for an additional
reviewer.

	- Garrett

On Tue, 2011-05-10 at 09:41 +0400, Yuri Pankov wrote:
> Hi,
> 
> webrev for "992 towlower/towupper are broken":
> 
> https://www.xvoid.org/illumos/webrev/992-localedef/
> 
> There are two parts in this, first is simple - fix a typo in ctype.c
> which was breaking __maplower_ext. The second one is more involved -
> I've added a data/ctype.sh script, which combines LC_CTYPE sections from
> all data/*.UTF-8.src files; the result is used when compiling the locale
> sources, while stripping the existing LC_CTYPE section (Makefile). This
> should give us the same character mapping tables, character
> classifications, etc. in all UTF-8 locales (that's what other OS do,
> anyway).
> 
> 
> Yuri
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list