[illumos-Developer] Webrev #534: DMA KVA cache attributes incorrect

[Michael Tsymbalyuk]

Well,

on my opinion, having #ifdef SPARK looks good, because
that leaves all flags/attributes combinations on programmers
choice.

Michael Tsymbalyuk

> On Tue, 2011-05-10 at 11:31 -0400, Dan McDonald wrote:
> > On Tue, May 10, 2011 at 08:29:10AM -0700, Garrett D'Amore wrote:
> > > Sadly, on SPARC it isn't right.  On SPARC platforms it is impossible to
> > > allocate uncached memory, because the SPARC platform guarantees cache
> > > consistency.
> > > 
> > > I *think* this will be harmless because the flags don't appear to be
> > > used on SPARC, although I'm not terribly happy about that.  So I'd at a
> > > minimum add a comment above indicating that the flags are not used on
> > > SPARC.
> > 
> > Can/should you #ifndef SPARC the changes, then?
> 
> That would be one possible solution.
> 
> 	- Garrett
> 
> > 
> > Dan
> > 
> > _______________________________________________
> > Developer mailing list
> > Developer at lists.illumos.org
> > http://lists.illumos.org/m/listinfo/developer
> 
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer