[illumos-Developer] Webrev #534: DMA KVA cache attributes incorrect, 2nd time

Garrett D'Amore garrett at nexenta.com
Tue May 10 16:25:11 PDT 2011


A few notes.  

1.  Your hg comment should match the bug synopsis exactly.
2.  You need to not clear the flags or override them if they are nonzero.
3. The sparc comment should say "sparc mappings are always cacheable, as sparc guarantees cache coherency."

In general your changes are pretty good, just minor adjustments still needed.

Michael Tsymbalyuk <mtzaurus at gmail.com> wrote:

>Good day.
>
>Here is the second version of the fix for improper page cache attributes
>for DMA memory allocation that takes into account SPARC page caching.
>
>http://cr.illumos.org/view/aiz4m5ei/illumos-534-webrev/
>
>Sincerely,
>Michael Tsymbalyuk
>
>
>
>
>_______________________________________________
>Developer mailing list
>Developer at lists.illumos.org
>http://lists.illumos.org/m/listinfo/developer


More information about the Developer mailing list