[illumos-Developer] webrev #687: rpcgen should not generate absolute #includes

Vitaliy Gusev gusev.vitaliy at nexenta.com
Wed May 11 12:13:51 PDT 2011


On 05/11/2011 07:10 PM, Stepan Zastupov wrote:
> This patch introduce option -p to prevent rpcgen from generating
> includes with absolute paths.

Please check changes by cstyle. Some lines become more than 80 symbols.


rpc_main.c: 170: continuation line not indented by 4 spaces
rpc_main.c: 170: continuation should be indented 4 spaces
rpc_main.c: 174: line > 80 characters
rpc_main.c: 177: line > 80 characters
rpc_main.c: 177: continuation line not indented by 4 spaces
rpc_main.c: 177: continuation should be indented 4 spaces
rpc_main.c: 182: continuation line not indented by 4 spaces
rpc_main.c: 182: continuation should be indented 4 spaces
rpc_main.c: 185: continuation should be indented 4 spaces
rpc_main.c: 190: line > 80 characters
rpc_main.c: 194: line > 80 characters
rpc_main.c: 198: line > 80 characters
rpc_main.c: 198: continuation line not indented by 4 spaces
rpc_main.c: 198: continuation should be indented 4 spaces
rpc_main.c: 201: indent by spaces instead of tabs
rpc_main.c: 201: continuation should be indented 4 spaces
rpc_main.c: 210: continuation line not indented by 4 spaces
rpc_main.c: 210: continuation should be indented 4 spaces
rpc_main.c: 213: continuation should be indented 4 spaces
rpc_main.c: 289: continuation should be indented 4 spaces
rpc_main.c: 638: continuation line not indented by 4 spaces


> A few notes:
> 1) I use basename(3) function, which conforms to POSIX.1-2001. Is it fine?
> 2) I haven't documented the option since I'm not sure is '-p' a good name.
>
> http://cr.illumos.org/view/mchniy2i/illumos-687-webrev/
>
> --
> BR, Stepan.
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer




More information about the Developer mailing list