[illumos-Developer] webrev #687: rpcgen should not generate absolute #includes

[Stepan Zastupov]

Right. Passing the flag also caused a lot of changes, but I think it's
better than making another global variable.
On the other hand I could refactor the whole argument passing scheme
but it would cause more changes and
I don't think it's worth the effort.

On Wed, May 11, 2011 at 11:20 PM, Alexey Zaytsev
<alexey.zaytsev at gmail.com> wrote:
> On Wed, May 11, 2011 at 23:18, Gordon Ross <gordon.w.ross at gmail.com> wrote:
>> On Wed, May 11, 2011 at 11:10 AM, Stepan Zastupov
>> <stepan.zastupov at gmail.com> wrote:
>>> This patch introduce option -p to prevent rpcgen from generating
>>> includes with absolute paths.
>>> A few notes:
>>> 1) I use basename(3) function, which conforms to POSIX.1-2001. Is it fine?
>>> 2) I haven't documented the option since I'm not sure is '-p' a good name.
>>>
>>> http://cr.illumos.org/view/mchniy2i/illumos-687-webrev/
>>
>> I took a quick look, and was surprised at the size of the changes.
>> How did the changes get so large?  Can you describe what you did?
>
> A good part of the changes seems to be due to moving include
> processing to a helper function.
>