[illumos-Developer] webrev: 650 grep support for -q would be useful

[Yuri Pankov]

On Wed, May 04, 2011 at 09:06:30AM +0400, Yuri Pankov wrote:
> On Mon, May 02, 2011 at 06:25:35PM +0400, Yuri Pankov wrote:
> > Hi,
> > 
> > This webrev handles quite more than just adding '-q' support - it
> > actually removes cmd/egrep, cmd/fgrep, cmd/grep and makes grep_xpg4 the
> > default one. The reason for this is that egrep, fgrep and grep are all
> > different source (and quite weird one, in case of egrep) and grep_xpg4
> > provides all the functionality plus other options (such as '-q').
> > Manpages will be handled separately if this is to be accepted.
> > 
> > https://www.xvoid.org/illumos/webrev/650-grep-q/
> 
> Thanks to Gordon for reminding me about bsdgrep. I have a new webrev for
> this issue, import 20090930 (latest) version of bsdgrep, which is
> option'ally compatible with GNU grep and has all the stuff we would have
> issues for in the future (-R is one of them, which doesn't exist in any
> grep we have in the tree now, so I've chosen to import bsdgrep instead
> of using xpg4 one).
> 
> http://www.xvoid.org/illumos/webrev/650-bsdgrep/
> 
> Some basic performance testing was done (see other messages in this
> thread) and doesn't show any real showstoppers for this import/change.
> 
> Comments are welcome..

The question is the same - what do you guys think about importing this
after the discussion it caused? Just simple yes or no would be fine.


Yuri