[illumos-Developer] webrev #687: rpcgen should not generate absolute #includes

[Gary Mills]

On Thu, May 12, 2011 at 11:11:57AM -0400, Gordon Ross wrote:
> On Thu, May 12, 2011 at 7:37 AM, Stepan Zastupov
> <stepan.zastupov at gmail.com> wrote:
> > Here is the updated patch:
> > http://cr.illumos.org/view/0ig2ulcs/illumos-687-webrev/
> >
> > This version makes cstyle happy.

> If we look at, for example, this generated file:
>   usr/src/uts/common/idmap/idmap_xdr.c
> The generated "top matter" contains:
>   #include "/tank/ws/nfslm1/usr/src/uts/common/rpcsvc/idmap_prot.h"

Ah, so it does, although mine has a different absolute path.  I guess
I've never seen that because I always put my *.x file in the same
directory as my Makefile.

> If I understand correctly, with the proposed -p option, this would be:
>   #include "idmap_prot.h"
> 
> What I'd prefer to have in cases like this is:
>   #include "rpcsvc/idmap_prot.h"

Yes, /usr/include/rpcsvc contains a collection of *.x and
corresponding *.h files.  What is the real problem here?  What is
really missing in rpcgen?  Does it need a search path for *.x files,
for example?

-- 
-Gary Mills-        -Unix Group-        -Computer and Network Services-