[illumos-Developer] review request - webrev for bug # 1027

[Mike Harsch]

Yes, here's the change in action (notice the new 'updates' field):

-bash-4.0# pwd
/usr/perl5/5.8.4/lib/i86pc-solaris-64int/auto/Sun/Solaris/Kstat
-bash-4.0# ls
Kstat.bs  Kstat.so
-bash-4.0# kstat -n vminfo
module: unix                            instance: 0
name:   vminfo                          class:    vm
         crtime                          0
         freemem                         14120907206
         snaptime                        2865516.52040151
         swap_alloc                      2050346806
         swap_avail                      47368289837
         swap_free                       47854964804
         swap_resv                       2537021773

-bash-4.0# cp 
/code/illumos-gate/usr/src/cmd/perl/5.8.4/staging/usr/perl5/5.8.4/lib/i86pc-solaris-64int/auto/Sun/Solaris/Kstat/Kstat.so 
./Kstat.so.new
-bash-4.0# cp Kstat.so Kstat.so.old
-bash-4.0# cp Kstat.so.new Kstat.so
-bash-4.0# kstat -n vminfo
module: unix                            instance: 0
name:   vminfo                          class:    vm
         crtime                          0
         freemem                         14126465632
         snaptime                        2865560.30196897
         swap_alloc                      2051212892
         swap_avail                      47389324529
         swap_free                       47876209938
         swap_resv                       2538098301
         updates                         92395

-bash-4.0#

On 5/14/11 12:58 PM, Garrett D'Amore wrote:
> The diffs look good. How have you tested this?
>
> - Garrett
>
> On Sat, 2011-05-14 at 10:29 -0600, Mike Harsch wrote:
>> Hello Illumos Developers,
>>
>> I would like to request review of a one-line change for Bug #1027
>> "add vminfo.updates to perl kstat module"
>> https://www.illumos.org/issues/1027
>>
>> The webrev can be found here:
>> http://harschsystems.com/bugs/illumos-1027-webrev/
>>
>>
>> This is my first attempt at contribution to illumos, so I wanted to
>> start small. I don't think you can get much smaller than this :-)
>>
>> Mike
>>
>> _______________________________________________
>> Developer mailing list
>> Developer at lists.illumos.org
>> http://lists.illumos.org/m/listinfo/developer
>
>