[illumos-Developer] Webrev for bug 864: at(1) should not popen /usr/bin/pwd

Gary Mills mills at cc.umanitoba.ca
Sun May 15 05:51:38 PDT 2011


On Sat, May 14, 2011 at 11:56:29AM -0700, Garrett D'Amore wrote:
> Line 677 seteuid(0) assumes that this is running as setid root, which
> may or may not be the case.  I'd prefer to see a call at line 667 to
> geteuid(), and then use that as the argument to seteuid() at line 677.

Yes, that's a better way.  See:

    http://cr.illumos.org/view/a4yxctmp/illumos864-1/

> If you can, I'd like to see how this does with autofs mounted
> directories, and compare that with its current use.  (I think it will be
> fine, but autofs can do weird things to getcwd().)

That was my second test, although I didn't mention that my home
directory was NFS-mounted with autofs.  I repeated all of the tests
with this new version, with successful results.

-- 
-Gary Mills-        -Unix Group-        -Computer and Network Services-



More information about the Developer mailing list