[illumos-Developer] review request - webrev for #1045 not clobbering perl build dir

Gordon Ross gordon.w.ross at gmail.com
Wed May 18 15:27:46 PDT 2011


On Wed, May 18, 2011 at 3:34 PM, Mike Harsch <mike at harschsystems.com> wrote:
> Thanks Albert,
>
> I've removed the contrib/copy_contrib target and the reference to
> contrib/copy_contrib from the clobber line.  I'd like to request another
> round of review  -- webrev is here:
> http://harschsystems.com/bugs/illumos-1045.2/

The dependencies on $(PERL_VERSIONS)
in clean,clobber look strange to me.  We don't want the
clean,clobber targets to create the 5.10.0 dir, do we?
I suspect these two lines:
    clean: $(PERL_VERSIONS)
    clobber: $(PERL_VERSIONS)
should instead be:
    clean: FRC
    clobber: clean
        ....



More information about the Developer mailing list