[illumos-Developer] review request - webrev for #1045 not clobbering perl build dir

[Garrett D'Amore]

That sounds right.  :-)

  -- Garrett D'Amore

On May 19, 2011, at 4:47 AM, Mike Harsch <mike at harschsystems.com> wrote:

> It doesn't complain.  I believe it's because $(RM) is '/usr/bin/rm -f' which happily returns even if the argument file doesn't exists.
> 
> -bash-4.0$ ls -l
> total 27
> drwxr-xr-x   3 mharsch  staff          4 May 18 20:43 5.10.0
> drwxr-xr-x   5 mharsch  staff          7 May 18 13:06 contrib
> -rw-r--r--   1 mharsch  staff       1494 May 18 20:37 Makefile
> -rw-r--r--   1 mharsch  staff       1494 May 18 17:14 Makefile.new
> -rw-r--r--   1 mharsch  staff       1819 May 18 20:37 Makefile.old
> -rw-r--r--   1 mharsch  staff       1050 May 17 13:55 req.flg
> drwxr-xr-x   2 mharsch  staff          3 May 18 13:08 skel
> -bash-4.0$ bldenv ~/mharsch-ws/illumos.sh 'make clobber'
> Build type   is  non-DEBUG
> RELEASE      is
> VERSION      is mharsch-ws
> RELEASE_DATE is May 2011
> 
> The top-level 'setup' target is available to build headers and tools.
> 
> Using /usr/bin/bash as shell.
> /usr/bin/rm -f -r 5.10.0
> -bash-4.0$ bldenv ~/mharsch-ws/illumos.sh 'make clobber'
> Build type   is  non-DEBUG
> RELEASE      is
> VERSION      is mharsch-ws
> RELEASE_DATE is May 2011
> 
> The top-level 'setup' target is available to build headers and tools.
> 
> Using /usr/bin/bash as shell.
> /usr/bin/rm -f -r 5.10.0
> -bash-4.0$
> 
> On 5/18/11 8:31 PM, Gordon Ross wrote:
>> If you run "make clobber" twice in a row,
>> does the second run get errors?
>> If so, make the $(RM) line:
>> -$(RM) -r $(PERL_VERSIONS)
>> Note the dash ("-") before $(RM)
>> 
>> Otherwise looks good.
>> 
>> Thanks,
>> Gordon
>> 
>> On Wed, May 18, 2011 at 10:04 PM, Mike Harsch <mike at harschsystems.com> wrote:
>>> On 5/18/11 4:27 PM, Gordon Ross wrote:
>>>> 
>>>> The dependencies on $(PERL_VERSIONS)
>>>> in clean,clobber look strange to me. We don't want the
>>>> clean,clobber targets to create the 5.10.0 dir, do we?
>>>> I suspect these two lines:
>>>> clean: $(PERL_VERSIONS)
>>>> clobber: $(PERL_VERSIONS)
>>>> should instead be:
>>>> clean: FRC
>>>> clobber: clean
>>>> ....
>>> 
>>> I agree.  This change has been made (along with Albert Lee's suggestion to
>>> remove the contrib/copy_contrib comment) here:
>>> 
>>>   http://harschsystems.com/bugs/illumos-1045.3/
>>> 
>>> Test results:
>>> 
>>> After running 'make' in usr/src/cmd/perl we have:
>>> 
>>> -bash-4.0$ ls -l
>>> total 17
>>> drwxr-xr-x   3 mharsch  staff          4 May 18 19:52 5.10.0
>>> drwxr-xr-x   5 mharsch  staff          7 May 18 13:06 contrib
>>> -rw-r--r--   1 mharsch  staff       1494 May 18 17:14 Makefile
>>> -rw-r--r--   1 mharsch  staff       1050 May 17 13:55 req.flg
>>> drwxr-xr-x   2 mharsch  staff          3 May 18 13:08 skel
>>> -bash-4.0$ bldenv ~/mharsch-ws/illumos.sh 'make clean'
>>> Build type   is  non-DEBUG
>>> RELEASE      is
>>> VERSION      is mharsch-ws
>>> RELEASE_DATE is May 2011
>>> 
>>> The top-level 'setup' target is available to build headers and tools.
>>> 
>>> Using /usr/bin/bash as shell.
>>> -bash-4.0$ ls -l
>>> total 17
>>> drwxr-xr-x   3 mharsch  staff          4 May 18 19:52 5.10.0
>>> drwxr-xr-x   5 mharsch  staff          7 May 18 13:06 contrib
>>> -rw-r--r--   1 mharsch  staff       1494 May 18 17:14 Makefile
>>> -rw-r--r--   1 mharsch  staff       1050 May 17 13:55 req.flg
>>> drwxr-xr-x   2 mharsch  staff          3 May 18 13:08 skel
>>> 
>>> Notice 'make clean' does nothing now.
>>> 
>>> -bash-4.0$ bldenv ~/mharsch-ws/illumos.sh 'make clobber'
>>> Build type   is  non-DEBUG
>>> RELEASE      is
>>> VERSION      is mharsch-ws
>>> RELEASE_DATE is May 2011
>>> 
>>> The top-level 'setup' target is available to build headers and tools.
>>> 
>>> Using /usr/bin/bash as shell.
>>> /usr/bin/rm -f -r 5.10.0
>>> -bash-4.0$ ls -l
>>> total 14
>>> drwxr-xr-x   5 mharsch  staff          7 May 18 13:06 contrib
>>> -rw-r--r--   1 mharsch  staff       1494 May 18 17:14 Makefile
>>> -rw-r--r--   1 mharsch  staff       1050 May 17 13:55 req.flg
>>> drwxr-xr-x   2 mharsch  staff          3 May 18 13:08 skel
>>> -bash-4.0$
>>> 
> 
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer