[illumos-Developer] [PATCH] modload: Unload modules by name

[Albert Lee]

On Thu, May 26, 2011 at 5:57 PM, Alexey Zaytsev
<alexey.zaytsev at gmail.com> wrote:
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev at gmail.com>
> ---
>
> Hi.
>
> I've seen all new nexenta people submit their first patches into
> illumos pretty quick, so to solidify this tradition, here's one from me.
>
> It lets you unload modules by name, as simple as
>
> modunload vioif virtio
>
> And yes, it takes multiple modules, and you can actually even add one more
> by using the -i option. The dependencies are not tracked, so you should pass
> inter-dependent modules in the right order.
>
> I did not rebuild the whole tree, but the code passed both cstyle and lint checks,
> and seems to work fine.
>

The advocates do try to request a full build when possible for an RTI,
although you don't have to do that until you're satisfied with the
review feedback.

<snip>

Why replace fatal() and error() with fprintf(stderr)? (As an aside,
webrev or some form other than inline diff would make it easier on
reviewers, so we don't need to pull up the unmodified files for
reference, and can quote line numbers. I was going to add inline
comments, but it quickly became hard to read).

Thanks,
-Albert