[illumos-Developer] webrev: 1039 /usr/lib/smbsrv/smbd prevents suspend

[Gordon Ross]

Thanks.  That's interesting re. no mutex hold needed or cv_signal, etc.
The documentation for cond_signal suggests you should hold the muex
which is probably what I was remembering.  (I thought it was required.
Maybe it was on some other system I used to worked on.)

I took that change out anyway.  Still trying to keep this "minimalist".
(Until my team gets in there with our demolition equipment:)

Gordon

On Fri, May 27, 2011 at 9:00 AM, Eric Schrock <eric.schrock at delphix.com> wrote:
> Yeah, sorry about that.  It looks much better.  You technically don't need
> to hold the mutex across cv_broadcast() (which should really be cv_signal in
> this case), but it's harmless - I wouldn't bother changing it unless you
> feel inspired.  Apart from the normal copyright addition cleanup, it looks
> good to me.
> - Eric