[illumos-Developer] [Review] 883 ZIL reuse during remount can lead to data corruption

Albert Lee trisk at opensolaris.org
Sun May 29 10:56:44 PDT 2011


Looks straightforward. The purpose of the "stub" lwb is to ensure
zil_sync and zil_commit_writer succeed?

-Albert

On Sun, May 29, 2011 at 10:22 AM, Garrett D'Amore <garrett at damore.org> wrote:
> Your bug description, and the fix, look good to me.  Thanks.
>
>   -- Garrett D'Amore
> On May 29, 2011, at 5:38 PM, Eric Schrock <eric.schrock at delphix.com> wrote:
>
> Thorough description of the problem in the bug report:
> https://www.illumos.org/issues/883
> Webrev here:
> http://dev1.illumos.org/~eschrock/cr/zil-remount/
> This has already been reviewed within Delphix by Matt Ahrens and Adam
> Leventhal, but I always like to give an opportunity for external review.  I
> will file the RTI on 5/31; let me know if you have any review feedback
> before then.
> The changes to ztest reproduce the problem easily and were used to verify
> the fix.  The bits have also been through many weeks of testing within
> Delphix.
> Thanks,
> - Eric
> --
> Eric Schrock
> Delphix
> 275 Middlefield Road, Suite 50
> Menlo Park, CA 94025
> http://www.delphix.com
>



More information about the Developer mailing list