[illumos-Advocates] RTI: 895 snoop lies about SMB errors

[Gordon Ross]

[ Let's try this again ]

webrev is here:
  http://www.yalms.org/cr/snoop/final/

mail_msg.txt attached.
I did not update the copyright in snoop_rport.c
where I only removed code (which moved over to
snoop_display.c).

$ hg outgoing -v
comparing with /tank/ws/illumos-clone
searching for changes

changeset:   13340:da0cf3ba8101
tag:         tip
user:        Gordon Ross <gwr at nexenta.com>
date:        Sat Apr 16 12:38:55 2011 -0400

description:
        895 snoop lies about SMB errors
        Reviewed by: Richard Lowe <richlowe at richlowe.net>
        Reviewed by: richard.elling at richardelling.com
        Approved by: ?

modified:
   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop.h
   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_display.c
   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rport.c
   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_smb.c

$hg pbchk
Copyright check:
usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rport.c: no copyright claim
for current year found

C style check:

Header format check:

Java style check:

Mapfile comment check:

File permission check:

Keywords check:

Comments check:

Checking for new tags:

Checking for multiple heads (or branches):

Checking for branch changes:

Checking for uncommitted changes:

Checking for merges:

-------------- next part --------------

==== Nightly distributed build started:   Sun Apr 17 10:24:35 EDT 2011 ====
==== Nightly distributed build completed: Sun Apr 17 14:10:07 EDT 2011 ====

==== Total build time ====

real    3:45:31

==== Build environment ====

/usr/bin/uname
SunOS sun40 5.11 oi_148b i86pc i386 i86pc

/opt/SUNWspro/bin/dmake
dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
number of concurrent jobs = 4

32-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/onspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)

64-bit compiler
/opt/onbld/bin/i386/cw -_cc
cw version 1.29
primary: /opt/onspro/SS12/bin/cc
cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
shadow: /usr/sfw/bin/gcc
gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)

/usr/java/bin/javac
java full version "1.6.0_21-b06"

/usr/ccs/bin/as
as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009

/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726

Build project:  group.staff
Build taskid:   368

==== Nightly argument issues ====


==== Build version ====

snoop

==== Tools build errors ====


==== Build errors (non-DEBUG) ====


==== Build warnings (non-DEBUG) ====


==== Elapsed build time (non-DEBUG) ====

real  1:24:28.3
user  2:43:47.6
sys     30:15.9

==== package build errors (non-DEBUG) ====


==== Build errors (DEBUG) ====


==== Build warnings (DEBUG) ====


==== Elapsed build time (DEBUG) ====

real  1:41:20.5
user  2:59:06.4
sys     34:58.7

==== package build errors (DEBUG) ====


==== Validating manifests against proto area ====


==== Check ELF runtime attributes ====


==== Diff ELF runtime attributes (since last build) ====


==== Find core files ====


==== Check lists of files ====


==== Impact on file permissions ====