[illumos-Advocates] RTI: 895 snoop lies about SMB errors

[Albert Lee]

On Sun, Apr 17, 2011 at 3:07 PM, Gordon Ross <gordon.w.ross at gmail.com> wrote:
> [ Let's try this again ]
>
> webrev is here:
>  http://www.yalms.org/cr/snoop/final/
>
> mail_msg.txt attached.
> I did not update the copyright in snoop_rport.c
> where I only removed code (which moved over to
> snoop_display.c).
>
> $ hg outgoing -v
> comparing with /tank/ws/illumos-clone
> searching for changes
>
> changeset:   13340:da0cf3ba8101
> tag:         tip
> user:        Gordon Ross <gwr at nexenta.com>
> date:        Sat Apr 16 12:38:55 2011 -0400
>
> description:
>        895 snoop lies about SMB errors
>        Reviewed by: Richard Lowe <richlowe at richlowe.net>
>        Reviewed by: richard.elling at richardelling.com
>        Approved by: ?
>
> modified:
>   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop.h
>   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_display.c
>   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rport.c
>   usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_smb.c
>
> $hg pbchk
> Copyright check:
> usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_rport.c: no copyright claim
> for current year found
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
>

Looks fine. I trust your reviewers.

-Albert