[illumos-Advocates] RTI 324 need serbian locale support

[Gordon Ross]

Looks fine to me.  One question on the lint that slipped past me:
Should we be asking about the build flags used in their build?
I forget whether that's in the mail_msg...

On Wed, Mar 23, 2011 at 12:25 AM, Garrett D'Amore <garrett at nexenta.com> wrote:
> webrev: http://mexico.purplecow.org/gdamore/webrev/serbian/
>
> Testing:  after onu'ing and pkg install pkg:/locale/sr :
>
> garrett at thinkpad:~$ env LANG=sr_BA.UTF-8 /usr/bin/date
> 22. mart 2011. 21.30.16 PDT
> garrett at thinkpad:~$ env LANG=sr_RS.UTF-8 /usr/bin/date
> 22. март 2011. 21.30.20 PDT
> garrett at thinkpad:~$ env LANG=sr_ME.UTF-8 /usr/bin/date
> 22.03.2011. 21.30.26 PDT
>
> You can notice each locale has (surprisingly!) different date
> representations.
>
> hg outgoing -v:
>
> garrett at thinkpad{8}> hg outgoing -v
> running ssh anonhg at hg.illumos.org "hg -R illumos-gate serve --stdio"
> comparing with ssh://anonhg@hg.illumos.org/illumos-gate
> searching for changes
>
> changeset:   13311:9dabee9307be
> tag:         tip
> user:        Garrett D'Amore <garrett at nexenta.com>
> date:        Tue Mar 22 21:01:27 2011 -0700
>
> description:
>        324 need serbian locale support
>        Reviewed by: Rich Lowe <richlowe at richlowe.net>
>
> modified:
>   usr/src/cmd/localedef/Makefile
> added:
>   usr/src/cmd/localedef/data/sr_BA.UTF-8.src
>   usr/src/cmd/localedef/data/sr_ME.UTF-8.src
>   usr/src/cmd/localedef/data/sr_RS.UTF-8.src
>   usr/src/pkg/manifests/locale-sr.mf
>
> hg pbchk (copyright complaints are expected... these files are from the
> same CLDR source as the other locales and haven't been updated since):
>
> Copyright check:
> usr/src/cmd/localedef/data/sr_BA.UTF-8.src: no copyright claim for
> current year found
> usr/src/cmd/localedef/data/sr_ME.UTF-8.src: no copyright claim for
> current year found
> usr/src/cmd/localedef/data/sr_RS.UTF-8.src: no copyright claim for
> current year found
>
> C style check:
>
> Header format check:
>
> Java style check:
>
> Mapfile comment check:
>
> File permission check:
>
> Keywords check:
>
> Comments check:
>
> Checking for new tags:
>
> Checking for multiple heads (or branches):
>
> Checking for branch changes:
>
> Checking for uncommitted changes:
>
> Checking for merges:
>
> mail_msg (still showing the same beadm lint bug... I'll get on the
> engineer's case on this):
>
> garrett at thinkpad{10}>
> cat /data/work/locale2/log/log.2011-03-22.15:35/mail_msg
>
> ==== Nightly distributed build started:   Tue Mar 22 13:37:17 PDT 2011
> ====
> ==== Nightly distributed build completed: Tue Mar 22 15:35:42 PDT 2011
> ====
>
> ==== Total build time ====
>
> real    1:58:25
>
> ==== Build environment ====
>
> /usr/bin/uname
> SunOS thinkpad 5.11 locale2 i86pc i386 i86pc
>
> /opt/SUNWspro/bin/dmake
> dmake: Sun Distributed Make 7.8 SunOS_i386 Patch 126504-01 2007/07/19
> number of concurrent jobs = 10
>
> 32-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> 64-bit compiler
> /opt/onbld/bin/i386/cw -_cc
> cw version 1.29
> primary: /opt/SUNWspro/bin/cc
> cc: Sun C 5.9 SunOS_i386 Patch 124868-10 2009/04/30
> shadow: /usr/sfw/bin/gcc
> gcc (GCC) 3.4.3 (csl-sol210-3_4-20050802)
>
> /usr/java/bin/javac
> java full version "1.6.0_21-b06"
>
> /usr/ccs/bin/as
> as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009
>
> /usr/ccs/bin/ld
> ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1726
>
> Build project:  group.staff
> Build taskid:   157
>
> ==== Nightly argument issues ====
>
>
> ==== Build version ====
>
> locale2
>
> ==== Make clobber ERRORS ====
>
>
> ==== Make tools clobber ERRORS ====
>
>
> ==== Tools build errors ====
>
>
> ==== Build errors (DEBUG) ====
>
>
> ==== Build warnings (DEBUG) ====
>
>
> ==== Elapsed build time (DEBUG) ====
>
> real  1:15:01.3
> user  6:40:53.1
> sys   1:18:38.3
>
> ==== Build noise differences (DEBUG) ====
>
>
> ==== package build errors (DEBUG) ====
>
>
> ==== Validating manifests against proto area ====
>
>
> ==== Check ELF runtime attributes ====
>
>
> ==== Diff ELF runtime attributes (since last build) ====
>
> 11508c11508
> < lib/svc/bin/svc.startd: RPATH=/usr/lib/fm
> ---
>> lib/svc/bin/svc.startd: RPATH=/lib/fm
>
> ==== 'dmake lint' of src ERRORS ====
>
>
> ==== Elapsed time of 'dmake lint' of src ====
>
> real    27:44.6
> user  1:37:47.4
> sys     32:50.0
>
> ==== lint warnings src ====
>
> "../common/be_utils.c", line 3525: warning: argument unused in function:
> pool_mntpt in be_create_menu (E_FUNC_ARG_UNUSED)
>
> ==== lint noise differences src ====
>
>
> ==== cstyle/hdrchk errors ====
>
>
> ==== Find core files ====
>
>
> ==== Check lists of files ====
>
>
> ==== Impact on file permissions ====
>
>
>
>
> _______________________________________________
> Advocates mailing list
> Advocates at lists.illumos.org
> http://lists.illumos.org/m/listinfo/advocates
>