[illumos-Developer] BSD iconv (was Closed-bin accords of the OpenSolaris conference... )

[Garrett D'Amore]

Btw,

The way I see it, we will probably doing a "port" and "adaptation" of
Gabor's code.  Our libc and style guidelines are different.  There may
be somewhat different locale names, there maybe additional or fewer
encodings.  We probably don't need or want GNU compat.  Etc.

Gabor, I want to thank you for making your work available under a
license which allows us to make use of it.  You should not feel
compelled in any way to do anything for Illumos or Solaris that you
don't want to.  There are plenty of volunteers in our group who can take
your work and make the necessary adaptations for us; you've already done
the heavy lifting!

	- Garrett

On Fri, 2010-08-13 at 13:37 +0200, Joerg Schilling wrote:
> Gabor Kovesdan <gabor at freebsd.org> wrote:
> 
> > > I did not yet look into this part of the code. I was looking at the Solaris
> > > implementation and the size of some of the modules on Solaris.
> > >
> > > BTW: is there a way to download it as a whole as e.g. a TAR archive?
> > >    
> > I'll provide that soon, for now I still have one issue to look at and 
> > also having some unrelated high-priority items on my TODO.
> 
> If we agree on a way that allows to have an identical source, we could start 
> with an integration now.
> 
> > > You could include a module local include file that hides the inclusion of
> > > <sys/cdefs.h>. It is always better to have such local portability needs
> > > implemented only once.
> > >
> > >    
> > As I explained before, that include is a must in each file for us.
> 
> This is why I explained how to avoid a direct include of a non-standard include 
> by including a local file instead.
> 
> 
> > > Does this mean that you believe you are ready for integration from your view?
> > >    
> > It's a complex issue but yes, I think so. We have to test it thoroughly 
> > with Ports Collection. The last portbuild failed with some issues, which 
> > I resolved since then. Now I'm waiting for the responsable parties to 
> > have some free resources for my new patch.
> 
> If you believe that your code is OK otherwise, why not start with a port to 
> OpenSolaris now?
> 
> > > Maybe we can even hide the differences in local files included with
> > > #include "x.h". I see<sys/cdefs.h>  (as mentioned already) and I see the need
> > > to keep /usr/include/iconv.h from Solaris and to put anything FreeBSD has into
> > > an additional local include file.
> > >    
> > Why to do that? Our iconv.h may already be compatible with yours 
> > (compatible in the way that by replacing the include, everything will 
> > still compile). It already seems to be compatible with GNU iconv.h, I 
> > can compile everything with our iconv.h but linking to GNU libiconv.
> 
> I like to keep the file /usr/include/iconv.h from Solaris without any changes
> for compatibility reasons. For the parts that are specific to you 
> implementation, we need local additions.
> 
> > > "GNU compatibility" at iconv level may more be a problem on OpenSolaris as GNU
> > > iconv (without manually adding aliases) will not recognize many locale names
> > > used by Solaris since the late 1980s even though these names are still
> > > permitted by the standard.
> > >    
> > We have lots of non-GNU aliases and all GNU ones are supported (except 
> > one). Besides, adding further aliases is very easy.
> 
> OK, so we need to first do a port and then compare the list of names from 
> iconv -l with the list obtained from Solaris SXCE and then check whether we 
> need to add aliases.
> 
> Jörg
>