[illumos-Developer] webrev: ZFS FRMI scheme fix

[Mike Riley]

On 12/04/10 18:55, Garrett D'Amore wrote:
> http://mexico.purplecow.org/gdamore/webrev/zfs-fmri/
>
> This fixes an FMRI scheme bug, which fails to properly consider that
> hot-spares are vdevs that participate within a ZFS pool.  This failure
> means that a failing hot spare might not be noticed within the zpool.
>
> (A separate bug, to monitor zpool vdevs via an FMA plugin we wrote, will
> be coming along soon.  That plugin depends upon this fix.)
>
> We've been using this change as part of NexentaStor 3.0.3 and 3.0.4 for
> about 5 months or so now, so its pretty well tested.
>
> Please let me know if you have any feedback.

That looks good to me Garrett.

This fix could have helped me a while back when I had a failed hot spare *and* one of the drives 
in my RAIDZ pool had failed as well.  Luckily in my case I had enough room on my boot drive in a 
slice to hold the data I needed to keep from the RAIDZ volume, so recovery and reconfiguring the 
RAIDZ was quite painless.  Having your FMA plugin would have been a big help in getting the 
warning of the failures, too.

Mike