[illumos-Developer] 342 Remove libntfs dependency on pkg:/library/gnome/gnome-vfs

Albert Lee trisk at opensolaris.org
Sun Dec 5 20:00:32 PST 2010


On Sun, Dec 5, 2010 at 10:41 PM, McBofh <McBofh at gmail.com> wrote:
> On  6/12/10 12:38 PM, Albert Lee wrote:
>>
>> This is already reviewed by Rich (who approved the copyright header
>> removal), and by Garrett, but I'll start documenting my changes here.
>>
>> Webrev, mail_msg, hg pbchk, and hg outgoing -v:
>> http://pkgdev.openindiana.org/~trisk/il_342_libntfs_gnomevfs/
>> http://pkgdev.openindiana.org/~trisk/mail_msg_342
>> http://pkgdev.openindiana.org/~trisk/pbchk_342
>
>
> Pretty sure you shouldn't be removing Rich's copyright line
> from the exception list.

He made changes to support the library dependencies pulled in by
gnome-vfs, and the copyright header was reverted along with everything
else, at his suggestion.

>
> Also, your CR says "probably never installed" - since you're
> removing this code, surely you should confirm that it isn't
> actually installed, rather than supposing?

I've confirmed this, and I'll update bug with the details. Thanks.

-Albert



More information about the Developer mailing list