[illumos-Developer] BEADM [WEBREV] 418 replace beadm by tbeadm with gettext support

[Garrett D'Amore]

This looks pretty good.  I have the following items:

Makefile: line 21.  You have to preserve the original Oracle copyright 
on the Makefile.  You can add the Nexenta one though.

Makefile: lines 37 - 39.  Where did these come from.  You're not using 
libumem, perhaps you don't need these lint overrides.  Please try 
removing them and checking lint.

Makefile: line 30. Where does Makefile.ctf come from?  I think you 
probably don't need it.  (The ZFS commands use it, but I don't 
understand why...)

Makefile: line 34:  I think you can probably remove this line too.  
beadm itself doesn't access any files, but instead relies on libbe to do 
its work.  Also, there are no $(INCS), and I don't think you're using 
any interfaces that are sensitive to -D_REENTRANT.

beadm.c: line 48:  Please make this "SYS_TEST" to match the other 
definitions used elsewhere.  (Note that this definition should never be 
used, as Makefile.cmd supplies a -DTEXT_DOMAIN definition.)

The rest of this looks really good.

Thanks!

  - Garrett

On 12/13/10 12:29 PM, Alexander Stetsenko wrote:
> No more message table and ids, no more gettext("yes"), gettext("no") - 
> nl_langinfo is used instead.
> This should satisfy all fixing requests:
>
> http://cr.illumos.org/view/snrfw6w7/
>
> Please, review it again,
>
> hg out -v:
> changeset:   13257:53eaa15cc930
> tag:         tip
> user:        Alexander Stetsenko <ams at nexenta.com>
> date:        Mon Dec 13 23:18:17 2010 +0300
>
> description:
>         418 replace beadm by tbeadm with gettext support
>         Reviewed by: roland.mainz at nrubsig.org
>         Reviewed by: gordon.w.ross at gmail.com
>         Reviewed by: trisk at opensolaris.org
>         Approved by: garrett at nexenta.com
>
> modified:
>    usr/src/cmd/beadm/Makefile
>    usr/src/pkg/manifests/install-beadm.mf
> added:
>    usr/src/cmd/beadm/beadm.c
> removed:
>    usr/src/cmd/beadm/BootEnvironment.py
>    usr/src/cmd/beadm/__init__.py
>    usr/src/cmd/beadm/beadm.py
>    usr/src/cmd/beadm/messages.py
>    usr/src/lib/libbe/tbeadm/Makefile
>    usr/src/lib/libbe/tbeadm/tbeadm.c
>
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer