[illumos-Developer] BEADM [WEBREV] 418 replace beadm by tbeadm with gettext support

[Alexander Stetsenko]

14.12.2010 00:33, Garrett D'Amore пишет:
> This looks pretty good. I have the following items:
>
> Makefile: line 21. You have to preserve the original Oracle copyright 
> on the Makefile. You can add the Nexenta one though.
>
> Makefile: lines 37 - 39. Where did these come from. You're not using 
> libumem, perhaps you don't need these lint overrides. Please try 
> removing them and checking lint.
>
> Makefile: line 30. Where does Makefile.ctf come from? I think you 
> probably don't need it. (The ZFS commands use it, but I don't 
> understand why...)
>
> Makefile: line 34: I think you can probably remove this line too. 
> beadm itself doesn't access any files, but instead relies on libbe to 
> do its work. Also, there are no $(INCS), and I don't think you're 
> using any interfaces that are sensitive to -D_REENTRANT.
>
> beadm.c: line 48: Please make this "SYS_TEST" to match the other 
> definitions used elsewhere. (Note that this definition should never be 
> used, as Makefile.cmd supplies a -DTEXT_DOMAIN definition.)
>
> The rest of this looks really good.
>
> Thanks!
>
> - Garrett
>

FIKSED:
http://cr.illumos.org/view/batjna4x/

Ready 4 Push?