[illumos-Developer] BEADM [WEBREV] 418 replace beadm by tbeadm with gettext support

[Gordon Ross]

On Mon, Dec 13, 2010 at 3:29 PM, Alexander Stetsenko <ams at nexenta.com> wrote:
> No more message table and ids, no more gettext("yes"), gettext("no") -
> nl_langinfo is used instead.
> This should satisfy all fixing requests:
>
> http://cr.illumos.org/view/snrfw6w7/

I like this better.  I have one more suggestion.
As you replaced the print_errmsg() calls, it looks like you
split some of them into multiple printf/fprintf calls, each
with gettext lookups with a part of the original gettext
argument string.

I assume this was to satisfy cstyle complaints.  However,
doing this will mean that any existing translation files we
might have from the previous xgettext extraction will not
work with the new xgettext extraction.

It's preferable to avoid changing the strings passed to
gettext where possible, to reduce costs of updating the
localized (translated) message files.

I suggest you save a copy of the original messages.po
file (you have to comment out a $(RM) in $SRC/Makefile.msg.targ
to save that.  Then do make _msg with your new stuff and
try to minimize changes in that file.

Otherwise this looks good to me.
Thanks for taking the feedback.

Gordon