[illumos-Developer] Please review: Fix Bug #432 - Memory leak insmbd/libsmb smb_idmap_getsid

[Garrett D'Amore]

Looks ok to me, but please get at least one more reviewer, as I did not take care to track the object lifetimes in my review, which was rather cursory.

Sent from my Android phone using TouchDown (www.nitrodesk.com)


-----Original Message-----
From: Gordon Ross [gordon.w.ross at gmail.com]
Received: Tuesday, 30 Nov 2010, 1:06pm
To: illumos-dev [developer at lists.illumos.org]
Subject: [illumos-Developer] Please review: Fix Bug #432 - Memory leak insmbd/libsmb smb_idmap_getsid


Note: idmap_get_mappings() returns an array of structures
containing strings allocated by strdup().  The caller has to
free those before freeing the array.

I'm testing this fix.  Please review:

http://cr.illumos.org/view/wzig7gbx/

Thanks,
Gordon

_______________________________________________
Developer mailing list
Developer at lists.illumos.org
http://lists.illumos.org/m/listinfo/developer