[illumos-Developer] Please review: Fix Bug #432 - Memory leak insmbd/libsmb smb_idmap_getsid

Joshua M. Clulow josh at sysmgr.org
Tue Nov 30 14:55:27 PST 2010


On 1 December 2010 09:37, Garrett D'Amore <Garrett.D'Amore at nexenta.com> wrote:
> Looks ok to me, but please get at least one more reviewer, as I did not take care to track the object lifetimes in my review, which was rather cursory.

Usage of smb_idmap_batch_{create,destroy}() appears limited to a few
files.  In these files the smb_idmap_batch_t is allocated locally in a
function and its use is bracketed by the create/destroy calls.

-- 
Joshua M. Clulow
UNIX Admin/Developer
http://blog.sysmgr.org



More information about the Developer mailing list